Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNAFUSION: use config files instead of nf-core hasta profile #3868

Merged
merged 12 commits into from
Nov 12, 2024

Conversation

rannick
Copy link
Contributor

@rannick rannick commented Oct 21, 2024

Description

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@rannick rannick marked this pull request as ready for review November 11, 2024 11:48
@rannick rannick requested a review from a team as a code owner November 11, 2024 11:48
@rannick rannick self-assigned this Nov 11, 2024
@rannick
Copy link
Contributor Author

rannick commented Nov 11, 2024

Tested with a case on stage, after review, one more test on prod should be done

@diitaz93 diitaz93 self-requested a review November 11, 2024 12:50
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@rannick rannick merged commit bc10c5c into master Nov 12, 2024
9 checks passed
@rannick rannick deleted the rnafusion_use_config_instead_of_profile branch November 12, 2024 10:53
@rannick
Copy link
Contributor Author

rannick commented Nov 12, 2024

Log deploy... done.
cg, version 64.4.24
remote: Enumerating objects: 34, done.
remote: Counting objects: 100% (34/34), done.
remote: Compressing objects: 100% (17/17), done.
remote: Total 34 (delta 17), reused 26 (delta 15), pack-reused 0 (from 0)
Unpacking objects: 100% (34/34), done.
From https://github.com/Clinical-Genomics/cg
   b70a21e..087fa6c  master     -> origin/master
 * [new branch]      make-sfffetching-apptag-base -> origin/make-sfffetching-apptag-base
 * [new tag]         v64.4.24   -> v64.4.24
From https://github.com/Clinical-Genomics/cg
 * [new tag]         v64.4.23   -> v64.4.23
Already on 'master'
Your branch is behind 'origin/master' by 4 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
Updating b70a21e..087fa6c
Fast-forward
 .bumpversion.cfg                 |  2 +-
 cg/__init__.py                   |  2 +-
 cg/meta/workflow/rnafusion.py    | 11 ++++-------
 cg/models/cg_config.py           |  3 +++
 cg/models/rnafusion/rnafusion.py | 11 -----------
 cg/store/crud/read.py            |  2 +-
 pyproject.toml                   |  2 +-
 tests/conftest.py                | 10 +++++-----
 8 files changed, 16 insertions(+), 27 deletions(-)
/home/hiseq.clinical
INFO  [alembic.runtime.migration] Context impl MySQLImpl.
INFO  [alembic.runtime.migration] Will assume non-transactional DDL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants