Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file filter to not manipulate indices #3880

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

islean
Copy link
Contributor

@islean islean commented Oct 23, 2024

Description

The filter_delivery_files changes the length of a list which it is still looping through, causing a list index out of range error. This PR reworks the filter.

Added

Changed

Fixed

  • The filter_delivery_files method does not manipulate the list indices

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b patch-file-filter -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean requested a review from a team as a code owner October 23, 2024 08:47
Copy link

Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great patch 💯

@islean
Copy link
Contributor Author

islean commented Oct 23, 2024

Tested in stage and it got to the move_files step ✅

@islean islean merged commit 43496c8 into master Oct 23, 2024
9 checks passed
@islean islean deleted the patch-file-filter branch October 23, 2024 09:06
@islean
Copy link
Contributor Author

islean commented Oct 23, 2024

Deployed to production:

Log deploy... done.
cg, version 64.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants