-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pydantic): Restart branch #3893
Conversation
@islean Tried to force validation of capture kit version and genome build. What do you think? I´m off next week so I won't be able to test it. |
@henrikstranneheim Looks promising! I can test it next week and merge it if successful! |
@islean @mathiasbio Is there a good test case on stage for this one? |
@islean @mathiasbio Is there a good test case on stage for this one? |
Sorry, I was sick for a few days but I think @mathiasbio should know this better than me and he probably knows if there are still testing issues with regards to Balsamic. When I wanted to test some fixes I ran the stage binary with the prod config and |
|
cg generate delivery-report, 👍
|
@islean Thx! Ready for a review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Deployed to prod:
|
Description
Added
Changed
Fixed
How to prepare for test
us
paxa
How to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan