Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pydantic): Restart branch #3893

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Oct 25, 2024

Description

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b update-pydantic-qcmetrics-2

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@henrikstranneheim
Copy link
Contributor Author

@islean Tried to force validation of capture kit version and genome build. What do you think? I´m off next week so I won't be able to test it.

@islean
Copy link
Contributor

islean commented Oct 25, 2024

@islean Tried to force validation of capture kit version and genome build. What do you think? I´m off next week so I won't be able to test it.

@henrikstranneheim Looks promising! I can test it next week and merge it if successful!

@henrikstranneheim henrikstranneheim marked this pull request as ready for review November 4, 2024 07:31
@henrikstranneheim henrikstranneheim requested a review from a team as a code owner November 4, 2024 07:31
@henrikstranneheim
Copy link
Contributor Author

@islean @mathiasbio Is there a good test case on stage for this one?

@henrikstranneheim
Copy link
Contributor Author

@islean @mathiasbio Is there a good test case on stage for this one?

@islean
Copy link
Contributor

islean commented Nov 6, 2024

@islean @mathiasbio Is there a good test case on stage for this one?

Sorry, I was sick for a few days but I think @mathiasbio should know this better than me and he probably knows if there are still testing issues with regards to Balsamic. When I wanted to test some fixes I ran the stage binary with the prod config and cg generate delivery-report --dry-run on a production case. Should probably work for this PR too?

Copy link

sonarqubecloud bot commented Nov 7, 2024

@henrikstranneheim
Copy link
Contributor Author

cg generate delivery-report, 👍

1:11] [hiseq.clinical@hasta:~] [S_base]  $ /home/proj/stage/bin/miniconda3/envs/S_cg/bin/cg --config /home/proj/production/servers/config/hasta.scilifelab.se/cg.yaml generate delivery-report solidlemming --dry-run
.
.
.
        <!-- Signature -->
          <div class="container mb-5">
  <h3 class="mb-4">Signatur för godkännande av rapport</h3>
  <div>
    Valtteri Wirta<br />
    Director, Clinical Genomics
  </div>
</div>
          <!-- Ticket communication -->

  <div class="container">
    <div class="alert alert-info" role="alert">
      All kommunikation gällande ordern, såsom tillägg, avvikelser eller ev undantag i metoden från
      Clinical Genomics, finns tillgänglig i SupportSystem och är länkad till ärendets ticket:
      <a class="alert-link">#1000775</a>. En stängd ticket kan närsomhelst öppnas upp igen för frågor.
    </div>
  </div>

        </div>
        <!-- Report footer -->
        <div class="card-footer text-center text-body-secondary">Slut på rapport</div>
      </div>
    </div>
  </body>
</html>
[11:14] [hiseq.clinical@hasta:~] [S_base]  $

@henrikstranneheim
Copy link
Contributor Author

@islean Thx! Ready for a review!

Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henrikstranneheim henrikstranneheim merged commit 9da6f17 into master Nov 11, 2024
9 checks passed
@henrikstranneheim henrikstranneheim deleted the update-pydantic-qcmetrics-2 branch November 11, 2024 07:32
@henrikstranneheim
Copy link
Contributor Author

Deployed to prod:

Log deploy... done.
cg, version 64.4.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants