Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refactor): #3957

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Nov 20, 2024

Description

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b refactor-get-families-with-samples-2

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@henrikstranneheim henrikstranneheim requested a review from a team as a code owner November 20, 2024 09:56
@henrikstranneheim
Copy link
Contributor Author

###$ cg upload available-observations --dry-run, 👍
´´´
cg upload available-observations --dry-run
.
.
.
Will upload observations for brieforyx
----------------- OBSERVATIONS -----------------
Called undefined pydantic_serializer on HousekeeperAPI, please wrap
Called undefined dataclass_fields on HousekeeperAPI, please wrap
Called undefined pydantic_serializer on HousekeeperAPI, please wrap
Called undefined dataclass_fields on HousekeeperAPI, please wrap
Called undefined pydantic_serializer on HousekeeperAPI, please wrap
Called undefined dataclass_fields on HousekeeperAPI, please wrap
Called undefined pydantic_serializer on HousekeeperAPI, please wrap
Called undefined dataclass_fields on HousekeeperAPI, please wrap
Called undefined pydantic_serializer on HousekeeperAPI, please wrap
Called undefined dataclass_fields on HousekeeperAPI, please wrap
Called undefined pydantic_serializer on HousekeeperAPI, please wrap
Called undefined dataclass_fields on HousekeeperAPI, please wrap
Dry run. Would upload observations for brieforyx.

@henrikstranneheim henrikstranneheim merged commit 415ff99 into master Nov 20, 2024
9 checks passed
@henrikstranneheim henrikstranneheim deleted the refactor-get-families-with-samples-2 branch November 20, 2024 10:14
@henrikstranneheim
Copy link
Contributor Author

Deployed to prod

´´´
Log deploy... done.
cg, version 64.5.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant