Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assignment maf cases to special order) #4053

Merged
merged 11 commits into from
Jan 13, 2025
Merged

fix(assignment maf cases to special order) #4053

merged 11 commits into from
Jan 13, 2025

Conversation

ChrOertlin
Copy link
Contributor

Description

Adds assignment of MAF cases to a special order.

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@ChrOertlin ChrOertlin requested a review from a team as a code owner January 6, 2025 13:40
@ChrOertlin ChrOertlin marked this pull request as draft January 7, 2025 07:53
@ChrOertlin ChrOertlin marked this pull request as ready for review January 7, 2025 10:42
@diitaz93 diitaz93 self-requested a review January 7, 2025 12:28
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This will be changed soon when the improve order flow is deployed but I will make sure that this change is implemented in that branch too

@clingen-sthlm clingen-sthlm temporarily deployed to stage January 13, 2025 08:07 Inactive
@ChrOertlin ChrOertlin merged commit 1107b45 into master Jan 13, 2025
10 checks passed
@ChrOertlin ChrOertlin deleted the fix-maf-orders branch January 13, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants