Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket status for existing samples #4150

Open
wants to merge 10 commits into
base: ticket-tag-existing-data
Choose a base branch
from
Open

Ticket status for existing samples #4150

wants to merge 10 commits into from
+56 −2

Conversation

eliottBo
Copy link
Contributor

Description

Close #4006

Added

  • Ticket with only existing samples get the status open

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@eliottBo eliottBo requested a review from a team as a code owner January 23, 2025 14:11
@eliottBo eliottBo requested a review from Vince-janv January 23, 2025 15:37
@Vince-janv Vince-janv changed the base branch from master to ticket-tag-existing-data January 23, 2025 15:41
Vince-janv
Vince-janv approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean 👍

cg/meta/orders/utils.py Outdated Show resolved Hide resolved
tests/services/orders/submitter/test_order_submitter.py Outdated Show resolved Hide resolved
cg/meta/orders/utils.py Outdated Show resolved Hide resolved
eliottBo and others added 4 commits January 24, 2025 08:40
@eliottBo @Vince-janv
Update cg/meta/orders/utils.py
7efea83 
Co-authored-by: Vincent Janvid <69356202+Vince-janv@users.noreply.github.com>
@eliottBo @Vince-janv
Update tests/services/orders/submitter/test_order_submitter.py
384ea30 
Co-authored-by: Vincent Janvid <69356202+Vince-janv@users.noreply.github.com>
@eliottBo @Vince-janv
Remove space cg/meta/orders/utils.py
a3836a0 
Co-authored-by: Vincent Janvid <69356202+Vince-janv@users.noreply.github.com>
@eliottBo
Add import for Status constant in test_order_submitter.py
0965558
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@clingen-sthlm clingen-sthlm temporarily deployed to stage January 24, 2025 09:11 Inactive
@eliottBo
Copy link
Contributor Author

Test:

Screenshot 2025-01-24 at 10 21 53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vince-janv Vince-janv Vince-janv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order tickets containing ONLY existing samples should have the status "open"
3 participants
@eliottBo @Vince-janv @clingen-sthlm