Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cg workflow nallo panel #4155

Merged
merged 9 commits into from
Jan 30, 2025
Merged

Add cg workflow nallo panel #4155

merged 9 commits into from
Jan 30, 2025

Conversation

peterpru
Copy link
Member

@peterpru peterpru commented Jan 27, 2025

Description

This PR adds the generation of a Scout gene panel export and includes it in the cg workflow nallo config-case command.

For sysdev: the call to scout is the same as for raredisease, however, Nallo needs the gene panel information as a TSV file, and not as a bed file such as in raredisease/mip. Here the bed file is requested from scout, then the ## commented lines are removed, and the file is saved with the extension .tsv

Config-case triggers the gene panel command by having is_gene_panel_required set to True.

Added

  • cg workflow nallo panel

Changed

  • cg workflow nallo config-case triggers panel generation

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b add-nallo-gene-panel

How to test

  • Do cg workflow nallo panel --help
  • Do cg workflow nallo panel rightalpaca
  • Delete the contents of the rightalpaca folder
  • Do cg workflow nallo config-case rightalpaca

Expected test outcome

  • Check that panel command is shown.
image
  • Check that panel is generated and contents look as expected.

image

  • After removing the contents of the analysis folder and triggering config-case, make sure that the file is generated correctly as part of the config-case command.

image

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@peterpru peterpru added the nallo label Jan 27, 2025
@peterpru peterpru self-assigned this Jan 27, 2025
@peterpru peterpru marked this pull request as ready for review January 29, 2025 20:03
@peterpru peterpru requested a review from a team as a code owner January 29, 2025 20:03
@diitaz93 diitaz93 self-requested a review January 30, 2025 09:24
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

cg/cli/workflow/nallo/base.py Show resolved Hide resolved
cg/meta/workflow/analysis.py Outdated Show resolved Hide resolved
@peterpru peterpru merged commit f1e582d into master Jan 30, 2025
10 checks passed
@peterpru peterpru deleted the add-nallo-gene-panel branch January 30, 2025 11:43
@peterpru
Copy link
Member Author

stage deployed:
image

Production deployment:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants