Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate deliverables.yaml file for nallo #4156

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Conversation

rannick
Copy link
Contributor

@rannick rannick commented Jan 27, 2025

Description

Added

  • List of nallo file paths for hermes
  • Generate deliverables.yaml file for nallo

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

Sorry, something went wrong.

@rannick rannick requested a review from a team as a code owner January 27, 2025 14:57
@rannick rannick self-assigned this Jan 27, 2025
@rannick rannick marked this pull request as draft January 27, 2025 14:57
@peterpru peterpru added the nallo label Jan 27, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@rannick rannick changed the title add nallo resources Generate deliverables.yaml file Jan 30, 2025
@rannick rannick changed the title Generate deliverables.yaml file Generate deliverables.yaml file for nallo Jan 30, 2025
@rannick rannick marked this pull request as ready for review January 30, 2025 09:08
@diitaz93 diitaz93 self-requested a review January 30, 2025 09:24
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

cg/meta/workflow/nallo.py Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Sebastian Diaz <juan.sebastian.diaz.boada@scilifelab.se>
@rannick rannick merged commit 90c6f6f into master Jan 30, 2025
10 checks passed
@rannick rannick deleted the add_resources_nallo branch January 30, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants