Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) Set correct priority on case orders #4176

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Conversation

islean
Copy link
Contributor

@islean islean commented Feb 3, 2025

Description

Ever since #3815, all case orders, i.e. MIP-DNA, MIP-RNA, Balsamic, Balsamic-UMI, RNAFusion, and Tomte, have only gotten priority = standard set in LIMS. This PR remedies that miss and I will open a deviation for affected orders.

Added

Changed

Fixed

  • Case priority is set on samples for case orders

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean requested a review from a team as a code owner February 3, 2025 12:12
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clingen-sthlm clingen-sthlm temporarily deployed to stage February 3, 2025 12:29 Inactive
@islean
Copy link
Contributor Author

islean commented Feb 3, 2025

Works on stage:

image

Copy link

sonarqubecloud bot commented Feb 3, 2025

@islean islean merged commit b37f6eb into master Feb 3, 2025
10 checks passed
@islean islean deleted the set-case-priorities branch February 3, 2025 12:42
@islean
Copy link
Contributor Author

islean commented Feb 3, 2025

Deployed to the VMs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants