Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update files and tags for balsamic release 16.0.0 #117

Merged
merged 16 commits into from
Nov 19, 2024

Conversation

mathiasbio
Copy link
Contributor

@mathiasbio mathiasbio commented Aug 13, 2024

Description

NOTE: Don't merge until balsamic release 16.0.0 is validated and deployed!

This PR adjusts which files will be delivered and stored as changed with the new release of balsamic v16.0.0, which makes some quite large changes to the core workflow.

How to prepare for test

  • ssh to hasta.scilifelab.se
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_hermes -t hermes -b [THIS-BRANCH-NAME]

How to test

Expected test outcome

  • Check that all files can be stored and delivered in balsamic release 16 release branch
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch
  • Inform to ...

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (c9ef4b4) to head (e8c0aa6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   92.76%   92.83%   +0.07%     
==========================================
  Files          28       28              
  Lines         967      977      +10     
==========================================
+ Hits          897      907      +10     
  Misses         70       70              
Flag Coverage Δ
unittests 92.83% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathiasbio mathiasbio marked this pull request as ready for review October 14, 2024 15:15
@mathiasbio mathiasbio requested a review from a team as a code owner October 14, 2024 15:15
@mathiasbio mathiasbio merged commit 54ae97a into main Nov 19, 2024
2 checks passed
@mathiasbio mathiasbio deleted the updates_for_balsamic_release_16.0.0 branch November 19, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants