-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use QUAL for filtering in addition to GQ #117
Comments
Fix #117 - add a flag to allow QUAL filter instead of GQ
Just recently we had a case where the GQ seemed to be missing for somatic whole genome cases. This also led to the deletion of the case in loqusdb, perhaps reasonably so, but is it related to this issue? Adding the trace down below and tagging @ivadym who is going to look into possibilities that this originates in CG as well. To me it seems like this is not an issue with the SNV's but an issue with the SV's? Call ['loqusdb', '--config', 'loqusdb-somatic.yaml', 'load', '--case-id', 'selectbison', '--variant-file', 'SNV.somatic.selectbison.tnscope.clinical.filtered.pass.vcf.gz', '--sv-variants', 'SV.somatic.selectbison.svdb.clinical.filtered.pass.vcf.gz', '--qual-gq'] exit with a non zero exit code
2024-03-19 07:32:54 hasta.scilifelab.se loqusdb.commands.cli[36938] INFO Running loqusdb version 2.7.1
2024-03-19 07:32:54 hasta.scilifelab.se mongo_adapter.client[36938] INFO Connecting to uri:mongodb://loqusdb_writer:******@cg-mongo1-prod.scilifelab.se:XXXXX,cg-mongo2-prod.scilifelab.se:XXXXX,cg-mongo3-prod.scilifelab.se:27019
2024-03-19 07:32:54 hasta.scilifelab.se mongo_adapter.client[36938] INFO Connection established
2024-03-19 07:32:54 hasta.scilifelab.se mongo_adapter.adapter[36938] INFO Use database loqusdb-somatic
2024-03-19 07:32:54 hasta.scilifelab.se loqusdb.utils.vcf[36938] INFO Check if vcf is on correct format...
2024-03-19 07:32:54 hasta.scilifelab.se loqusdb.utils.vcf[36938] INFO Vcf file SNV.somatic.selectbison.tnscope.clinical.filtered.pass.vcf.gz looks fine
2024-03-19 07:32:54 hasta.scilifelab.se loqusdb.utils.vcf[36938] INFO Nr of variants in vcf: 2080
2024-03-19 07:32:54 hasta.scilifelab.se loqusdb.utils.vcf[36938] INFO Type of variants in vcf: snv
2024-03-19 07:32:54 hasta.scilifelab.se loqusdb.utils.vcf[36938] INFO Check if vcf is on correct format...
[W::hts_idx_load3] The index file is older than the data file: SV.somatic.selectbison.svdb.clinical.filtered.pass.vcf.gz.tbi
2024-03-19 07:33:01 hasta.scilifelab.se loqusdb.utils.vcf[36938] INFO Vcf file SV.somatic.selectbison.svdb.clinical.filtered.pass.vcf.gz looks fine
2024-03-19 07:33:01 hasta.scilifelab.se loqusdb.utils.vcf[36938] INFO Nr of variants in vcf: 2202
2024-03-19 07:33:01 hasta.scilifelab.se loqusdb.utils.vcf[36938] INFO Type of variants in vcf: sv
[W::hts_idx_load3] The index file is older than the data file: SV.somatic.selectbison.svdb.clinical.filtered.pass.vcf.gz.tbi
2024-03-19 07:33:01 hasta.scilifelab.se loqusdb.utils.load[36938] WARNING int() argument must be a string, a bytes-like object or a number, not 'NoneType' |
So it fails when parsing
|
Feel free to ping with a case: was it missing both GQ and QUAL? |
But we don't have this QUAL/GQ threshold logic for SVs, right? And all the variants in that VCF are SVs loqusdb/loqusdb/build_models/variant.py Lines 183 to 193 in a220269
|
Thanks! So based on what @ivadym wrote, it should not really be the same issue. But the NoneType issue is similar. I can have a look if you haven't already: it sure looks like this repo could use a little attention. 😂 |
It is related, but an additional complication. This case has a variant with neither type of quality for some arcane reason. VCF is a rather open format I guess, and all caller authors do not agree on classic convention I suppose. 😄 Will fix.
To me it looks like a bug in Sentieon TNscope, but that in turn looks like closed source corporate stuff? I don't quite approve, but I guess it is fast... |
Fix #117 corollary - if QUAL is . set to 0
Some callers, e.g. TNScope, will not output GQ FORMAT tags by default. It would be convenient to be able to use the QUAL tag to quality filter them before upload.
The text was updated successfully, but these errors were encountered: