Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4773 - separate RNA view genome build option #4775

Merged
merged 14 commits into from
Aug 26, 2024
Merged

Fix #4773 - separate RNA view genome build option #4775

merged 14 commits into from
Aug 26, 2024

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Aug 22, 2024

This PR adds a functionality or fixes a bug.

One can now view RNA alns in hg19 by setting rna_human_genome_build: 37 in the load config.
Screenshot 2024-08-23 at 14 11 55

Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. Fist book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout.target
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by CR
  • tests executed by DN

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.21%. Comparing base (c3b4276) to head (1904df8).
Report is 1 commits behind head on main.

Files Patch % Lines
...cout/server/blueprints/alignviewers/controllers.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4775      +/-   ##
==========================================
- Coverage   84.22%   84.21%   -0.01%     
==========================================
  Files         318      318              
  Lines       19161    19176      +15     
==========================================
+ Hits        16138    16149      +11     
- Misses       3023     3027       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
@dnil dnil marked this pull request as ready for review August 23, 2024 12:34
@northwestwitch northwestwitch self-assigned this Aug 26, 2024
Copy link
Member

@northwestwitch northwestwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just those pydantic checks that should at least swap names

@@ -499,6 +500,20 @@ def set_synopsis(cls, synopsis: Optional[Union[str, List]]) -> Optional[str]:
@model_validator(mode="before")
@classmethod
def format_build(cls, values) -> "CaseLoader":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be named format_rna_build and the function down (line 516) format_build?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also these 2 functions have some common code. Couldn't they be unified somehow?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, one way would be to break out the genome string check to a separate helper..

Copy link

sonarcloud bot commented Aug 26, 2024

@dnil dnil merged commit c74f219 into main Aug 26, 2024
25 checks passed
@dnil dnil deleted the sashimi_hg38 branch August 26, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants