Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated configuration for clustered env #138

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

bitchecker
Copy link
Contributor

Loading the right configuration on clustered environment in order to provide Load Balancing and Failover.

This solves #137

Loading the right configuration on clustered environment in order to
provide Load Balancing and Failover.

Modifiche di cui verrà eseguito il commit:
modificato:             docker-compose-nginx.yml
@bitchecker bitchecker requested a review from Clivern as a code owner December 10, 2024 18:37
@Clivern
Copy link
Owner

Clivern commented Dec 11, 2024

Hi @bitchecker,

Can you please update the docs too, I am fine with merging it

the following should be adjusted in
https://github.com/Clivern/Lynx/blob/main/docs/_documentation/Installation.md?plain=1#L99-L100
https://github.com/Clivern/Lynx/blob/main/README.md?plain=1#L79-L80

wget https://raw.githubusercontent.com/Clivern/Lynx/main/nginx-cluster.conf \
    -O nginx.conf
// Should be
wget https://raw.githubusercontent.com/Clivern/Lynx/main/nginx-cluster.conf \
    -O nginx-cluster.conf

@bitchecker
Copy link
Contributor Author

wget https://raw.githubusercontent.com/Clivern/Lynx/main/nginx-cluster.conf \
    -O nginx.conf
// Should be
wget https://raw.githubusercontent.com/Clivern/Lynx/main/nginx-cluster.conf \
    -O nginx-cluster.conf

I think that this is correct!
The default config name for nginx is nginx.conf so the name that you use for it is right, in fact, in the PR I'm just updating the config file, but the destination name remains the same.

@Clivern
Copy link
Owner

Clivern commented Dec 11, 2024

The PR should be updating docker-compose-cluster.yml Right? because docker-compose-nginx.ymlis for single node behind nginx.

What i meant if you change local config name that we mount, the docs should reflect that change otherwise the setup guide will be wrong.

Changes that will be committed:
modified:               README.md
modified:               docs/_documentation/Installation.md
@bitchecker
Copy link
Contributor Author

Hi @Clivern,
Thanks for explanation!

It's clear now because cloning the whole project is not even required!

I updated the code right now. 😃

@Clivern Clivern merged commit 2888637 into Clivern:main Dec 12, 2024
7 checks passed
@Clivern
Copy link
Owner

Clivern commented Dec 12, 2024

Thanks @bitchecker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants