-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize the project #23
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this shouldn't be working, since we don't have docker inside docker. Please also mount the host docker socket in the origamid container so that it should be able to launch containers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of things missing in this
- Celery needs a message broker, so we also need to setup that in docker-compose.yml
- Change name Dockerfile.txt to Dockerfile
- This won't work until origamid is able to create new container which is only possibly by mounting host docker unix domain socket. Configure this in the Dockerfile.
@fristonio I haven't yet completed it. I am working on it. 😄 |
Ok cool, just putting a WIP label so no one gets confused. 😅 |
@fristonio When I try locally, the error is |
Ok, I think the problem here is that the image is not tagged properly. Run |
Also, since origami-daemon exposes an API server to work with, you should also open the port when building the docker container. Google on how to expose ports in docker containers. |
@fristonio @RishabhJain2018 Done the changes! Added wrapper for easy installation too. Can you review this? |
please rename the |
@fristonio @RishabhJain2018 @techytushar Please review the PR! |
@gautamjajoo is the docker-compose setup working properly on your local machine? |
|
@techytushar Can you explain this part |
@techytushar Done the required changes. @fristonio Can you review? |
Added Docker files to run the project easily using Docker. Screencast
@fristonio @RishabhJain2018 @techytushar