update makefile, add install-client target #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enables to build client only - when building with DEFAULT_HOST environment variable set, default hostname is compiled in to the binary (no config file needed)
cviecco
reviewed
May 2, 2024
Makefile
Outdated
|
|
||
| cmd/keymasterd/binData.go: | ||
| -go-bindata -fs -o cmd/keymasterd/binData.go -prefix cmd/keymasterd/data cmd/keymasterd/data/... | ||
|
|
||
| install-client: init-config-host cmd/keymasterd/binData.go |
There was a problem hiding this comment.
Why do we still need init-config-host? Seems like you can delete both the file, the make target and all references in the make target.
There was a problem hiding this comment.
OK will do it. I just didn't want to do a large change
ph4r05
force-pushed
the
dklinec
branch
3 times, most recently
from
8c62140
to
238021d
Compare
cviecco
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
make install-clientfinished fine, keymaster login successful.Build with compiled-in default host