Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor tests enhancements #232

Merged

Conversation

cviecco
Copy link
Contributor

@cviecco cviecco commented May 27, 2024

No description provided.

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 32.17%. Comparing base (f35df8b) to head (9cd031c).

Files Patch % Lines
cmd/keymaster/main.go 22.22% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   32.09%   32.17%   +0.08%     
==========================================
  Files          75       75              
  Lines        9713     9718       +5     
==========================================
+ Hits         3117     3127      +10     
+ Misses       5957     5950       -7     
- Partials      639      641       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cviecco cviecco merged commit 413cb76 into Cloud-Foundations:master May 27, 2024
8 of 9 checks passed
ph4r05 added a commit to ph4r05/keymaster that referenced this pull request May 28, 2024
* add flavour, version command, fix version source (Cloud-Foundations#229)

- make makefile single source of truth for version
- trigger the flow in the tests

* minor tests enhancements (Cloud-Foundations#232)

---------

Co-authored-by: Dušan Klinec <ph4r05@gmail.com>
Co-authored-by: cviecco <cviecco@gmail.com>
ph4r05 added a commit to ph4r05/keymaster that referenced this pull request Jun 12, 2024
* add flavour, version command, fix version source (Cloud-Foundations#229)

- make makefile single source of truth for version
- trigger the flow in the tests

* minor tests enhancements (Cloud-Foundations#232)

* Docker cleanup (Cloud-Foundations#233)

* Removed unnecessary `start.sh`
* Updated Dockerfile to newer OS
* Cleaned up Dockerfile dirty hack for RSA keys

Co-authored-by: Espinoza, Erik <eespinoza@wackamoley.com>

* enable to specify agent connection to insert cert to (Cloud-Foundations#231)

* enable to specify agent connection to insert cert to

* add api

* bump version

---------

Co-authored-by: Dušan Klinec <dklinec@purestorage.com>

---------

Co-authored-by: Dušan Klinec <ph4r05@gmail.com>
Co-authored-by: cviecco <cviecco@gmail.com>
Co-authored-by: Erik Espinoza <7862514+erikespinoza@users.noreply.github.com>
Co-authored-by: Espinoza, Erik <eespinoza@wackamoley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants