fix(astro-engine): Add support for GIF, TIFF and AVIF image imports #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @oliverlynch! These changes all look good to me. The windows tests are having some issues but it doesn't look related, so I'm happy to merge this 👍 |
|
Thanks again @oliverlynch 🙂 This has been released in the latest Bookshop version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using astro:image to optimise image assets, which appeared to be working with bookshop until I added a company logo in GIF format.
error: No loader is configured for ".gif" files: src/assets/pages/community/page.md/logo.gifastro:image uses sharp by default to optimise images, which supports JPEG, PNG, WebP, GIF, AVIF, TIFF and SVG images. Currently bookshop build fails if GIF, TIFF or AVIF images are imported.
I have not tested this patch beyond importing a gif, tiff and avif image and building the site, which appears to work.
The tiff image does not render in the editor as tiff is not a supported image format in firefox, however the optimised version of the image on the live site is webp and renders correctly.