Change AbstractParser.php to support all Json encoded strings #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the RFC, (https://datatracker.ietf.org/doc/html/rfc7644#section-3.4.2.2) the comparison value rules are built on JSON Data Interchange format ABNF rules. That means that a comparison value such as
"test\""
should be parsed astest"
. However, the current implementation would not recognize this comparison value as a string.Therefore, the following changed were made:
json_decode()
instead oftrim()
to decode a string comparison value. This fixes several issues, such as escaped quotes being trimmed.