Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid crm_attribute and crm_master during transitions #18

Closed
ioguix opened this issue Apr 27, 2016 · 1 comment
Closed

Avoid crm_attribute and crm_master during transitions #18

ioguix opened this issue Apr 27, 2016 · 1 comment
Labels
enhancement
Milestone
v1.1.0

Comments

@ioguix
Copy link
Member

ioguix commented Apr 27, 2016

Because this commands set transient attributes, it frequently breaks the transitions and force the PEngine to recompute a new transition taking over the last one.

This is annoying as it changes the notify environment variables in the middle of a transition and require more cluster communication.

crm_master should be called only during the regular monitor action call.

crm_attribute can be replaced with attrd_updater.
@ioguix ioguix added this to the v1.1.0 milestone Apr 27, 2016
ioguix added a commit that referenced this issue Apr 27, 2016
@ioguix
Don't call _check_location if current action is not a monitor
25e9e93 
This should partly fix gh #18
ioguix added a commit that referenced this issue Apr 27, 2016
@ioguix
Set lsn_location as private attributes
f60f43a 
This patch replace every call of "crm_attribute" to set lsn_location by a
call to "attrd_updater --private". This avoid breaking a transition by
setting resource attributes as private attribute do not land inside the
CIB.

This takes part of the cleanup for gh issue #18.
ioguix added a commit that referenced this issue Apr 27, 2016
@ioguix
Remove the primary_node parameter
c147381 
This takes part of the gh issue #18 fix.

Setting primary node at the very end of a promote or during a
post-promote can breaks a transition and require a new (often useless)
transition to be computed.
@ioguix
Copy link
Member Author

ioguix commented Apr 27, 2016

After this 3 commits, I guess it's enough for this one.

@ioguix ioguix closed this as completed Apr 27, 2016
ioguix added a commit that referenced this issue May 30, 2016
@ioguix
Remove the primary_node parameter
b9dc889 
This takes part of the gh issue #18 fix.

Setting primary node at the very end of a promote or during a
post-promote can breaks a transition and require a new (often useless)
transition to be computed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@ioguix