avoid disappearing metrics for pacemaker nodes and resources #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ne-msft @steffenv-msft you might want to take a look at it, as it changes a bit the behavior of the cluster node metrics. |
|
marking as wip because it breaks current dashboards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements what we discussed at the end last week, following up some feedback we received from MSFT.
ha_cluster_pacemaker_nodesandha_cluster_pacemaker_resourcesnow will report a0value instead of a missing metric line for those status flags that are nottruein the CIB.This way, we correctly report all the possible combinations, including the ones where all the statuses are off. This will result in a more verbose metric set, but it's much clearer in intent and usable from a consumption perspective.
This PR also removes:
unknownnode type, which is not needed because the upstream data source hasmemberas a default value.status=""label value, previously used to work around the same issue the nodes metric had, now fixed properly.