Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version CLI flag #158

Merged
merged 4 commits into from
May 29, 2020
Merged

Conversation

stefanotorresi
Copy link
Member

This PR adds a --version CLI flags that shows the version and build time embedded in the binary via ldflags.

It also deprecates the --enable-timestamp: it's still usable, but no longer advertised in the help message, and using it will issue a warning message on startup.

Furthermore, invoking the --help flag will no longer exit with a non-0 code.

Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thx!

@MalloZup MalloZup merged commit 4a32a0f into ClusterLabs:master May 29, 2020
@stefanotorresi stefanotorresi deleted the feature/version-flag branch June 3, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants