Fix: hb_report: indicate the 'crm report' failure #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksei-burlakov
force-pushed
the
dev-check-report-error
branch
3 times, most recently
from
19723dc
to
df42f68
Compare
|
Can I use test it by patching files directly in an installed system? cd /usr/share/hawk/
curl -L https://github.com/ClusterLabs/hawk/pull/288.patch | patch -p2Or do I have to build a package and install it? |
Puma server doesn't directly use the
|
It is not enough to set |
Previously, even if the crm report had failed, the hawk would show the green status. In this change, we add reading ./tmp/pids/report.exit and ./tmp/reports/<report-file>.stderr We return the first line of the error message and the red status, if the execution has failed.
aleksei-burlakov
force-pushed
the
dev-check-report-error
branch
from
df42f68
to
1bda8e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, even if the crm report had failed, the hawk would show the green status. In this change, we add reading ./tmp/pids/report.exit and ./tmp/reports/.stderr We return the first line of the error message and the red status, if the execution has failed.