-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 65.68% 65.68%
=======================================
Files 4 4
Lines 204 204
Branches 57 57
=======================================
Hits 134 134
Misses 70 70 Continue to review full report at Codecov.
|
Just missing Windows bindings, adding 14 support was pretty easy I just need to compile them on the various platforms. I deployed cWS for Node 14 to my prod servers and it's running fine. |
@EricRabil Thank you for your PR. Please rebase this branch on latest master also master includes fix for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good ! Just one minor change needed
make.bat
Outdated
) | ||
|
||
cl /I targets/node-%v64%/include/node /I targets/node-%v64%/deps/uv/include /I targets/node-%v64%/deps/v8/include /I targets/node-%v64%/deps/openssl/openssl/include /I targets/node-%v64%/deps/zlib /EHsc /Ox /LD /Fedist/bindings/cws_win32_64.node src/*.cpp targets/node-%v64%/node.lib | ||
cl /I targets/node-%v72%/include/node /I targets/node-%v72%/deps/uv/include /I targets/node-%v72%/deps/v8/include /I targets/node-%v72%/deps/openssl/openssl/include /I targets/node-%v72%/deps/zlib /EHsc /Ox /LD /Fedist/bindings/cws_win32_72.node src/*.cpp targets/node-%v72%/node.lib | ||
cl /I targets/node-%v79%/include/node /I targets/node-%v79%/deps/uv/include /I targets/node-%v79%/deps/v8/include /I targets/node-%v79%/deps/openssl/openssl/include /I targets/node-%v79%/deps/zlib /EHsc /Ox /LD /Fedist/bindings/cws_win32_79.node src/*.cpp targets/node-%v79%/node.lib | ||
cl /I targets/node-%v83%/include/node /I targets/node-%v83%/deps/uv/include /I targets/node-%v83%/deps/v8/include /I targets/node-%v83%/deps/openssl/openssl/include /I targets/node-%v83%/deps/zlib /EHsc /Ox /LD /Fedist/bindings/cws_win32_79.node src/*.cpp targets/node-%v83%/node.lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Fedist/bindings/cws_win32_79.node
should point to 83 -> /Fedist/bindings/cws_win32_83.node
Also this branch should not include any bindings for other versions except node 14 |
Could you provide a bit more insight as to why you'd like bindings for versions earlier than 14 to be removed? Node 12 is the latest LTS, we should at least include support for that. |
@EricRabil will you are rebuilding already existing bindings as they already exists in master branch there is no need to change anything in those. So after merging this branch it should just merge new bindings only for version 14. TBH i would prefer to rebuild all bindings including version 14 before releasing to npm to be on the safe side. |
I removed the earlier bindings. I wasn’t able to build a windows binding for 14, but that’s because I couldn’t get a Windows development environment set up. |
@EricRabil better not to delete those bindings but remove changes which were done (you should be able to just copy already existing one from master branch) :) |
Ahh sorry, I’ll fix that. Edit: the original bindings are now in this branch. |
@goriunov hi there, are there any other changes you need from me? :) |
Looks good, i will try to merge this PR soon ! Thank you ! |
I only have a Mac, and am unsure how to build for Linux and Windows. However the Darwin build for Node 14 is working for me, I'll test it out on my projects and see how it fares.
Update: running fine for me on 14.1.0, however
npm run test
within the cWS repo is failing with the following: