Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to clara 0.18.0, use rule builder, fix missing listener method #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex-dixon
Copy link
Contributor

@alex-dixon alex-dixon commented May 28, 2018

#115

  • Upgrade to clara 0.18.0
  • Add empty fire-activations! to listeners to satisfy new protocol
  • Use clara.rules.dsl/build-rule in CLJ rule macro code paths
  • Add mk-session to create anonymous sessions in Clojure

@codecov
Copy link

codecov bot commented May 28, 2018

Codecov Report

Merging #116 into master will decrease coverage by 0.03%.
The diff coverage is 54.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   56.82%   56.79%   -0.04%     
==========================================
  Files          23       23              
  Lines        1714     1722       +8     
  Branches      114      107       -7     
==========================================
+ Hits          974      978       +4     
- Misses        626      637      +11     
+ Partials      114      107       -7
Impacted Files Coverage Δ
src/cljc/precept/listeners.cljc 50.38% <ø> (ø) ⬆️
src/cljc/precept/rules.cljc 65.25% <54.16%> (-7.48%) ⬇️
src/cljc/precept/query.cljc 80% <0%> (+15%) ⬆️
src/cljc/precept/impl/rules.cljc 100% <0%> (+44.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e4b579...1584d13. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant