Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle --help flags when argv.remainder! is used #87

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Correctly handle --help flags when argv.remainder! is used #87

merged 2 commits into from
Jul 19, 2019

Conversation

amorde
Copy link
Member

@amorde amorde commented Jul 10, 2019

@amorde amorde requested review from dnkoutso and segiddins July 10, 2019 07:35
@amorde
Copy link
Member Author

amorde commented Jul 10, 2019

Tests passed except for old Ruby versions that aren't on Travis anymore, I can update the config but maybe we should drop support for those versions?

@dnkoutso
Copy link
Contributor

Yes lets do the same set CocoaPods/CocoaPods does?

@dnkoutso dnkoutso mentioned this pull request Jul 15, 2019
Closed
@amorde
Copy link
Member Author

amorde commented Jul 15, 2019

Yup I'll do that in another PR before merging this

@dnkoutso
Copy link
Contributor

An attempt was made here #86

@dnkoutso
Copy link
Contributor

@amorde add a CHANGELOG bug fix entry and then point to 1-0-stable instead as I will do a 1.0.3 release for this.

@amorde
Copy link
Member Author

amorde commented Jul 19, 2019

@dnkoutso 1-0-stable branch is out of date, right now it's pointing to 1.0.1 instead of 1.0.2

Should I update it?

@amorde amorde force-pushed the amorde/help-flag branch from 881f2be to 84eef71 Compare July 19, 2019 22:34
@amorde amorde changed the base branch from master to 1-0-stable July 19, 2019 22:35
@amorde amorde force-pushed the amorde/help-flag branch from 84eef71 to e261a78 Compare July 19, 2019 22:38
@amorde
Copy link
Member Author

amorde commented Jul 19, 2019

Updated the stable branch, and re-targeted this PR

dnkoutso
dnkoutso reviewed Jul 19, 2019
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@amorde amorde force-pushed the amorde/help-flag branch 2 times, most recently from 537eac7 to c303c95 Compare July 19, 2019 22:45
@amorde amorde force-pushed the amorde/help-flag branch from c303c95 to ff997e1 Compare July 19, 2019 22:50
@dnkoutso dnkoutso merged commit 238244e into 1-0-stable Jul 19, 2019
@dnkoutso dnkoutso deleted the amorde/help-flag branch July 19, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnkoutso dnkoutso dnkoutso approved these changes

@segiddins segiddins segiddins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amorde @dnkoutso @segiddins