-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ruby 2.6 #671
Upgrade to Ruby 2.6 #671
Conversation
54feb9a
to
bdf3a59
Compare
@igor-makarov Please review |
Can you explain what Zeitwerk is and why it's useful? Also, how hard is it to integrate? Does it have performance benefits? |
bdf3a59
to
d7e087b
Compare
About the last commit,
|
It's Ruby thread-safe file loader (although CocoaPods no need to care about of thread-safe), No performance benefits. off-topic: For CLI application, maybe https://github.com/Shopify/bootsnap can help to reduce start up time |
4379dee
to
50b134f
Compare
In addition I upgrade WebMock |
dbd70e8
to
5631b90
Compare
Could you drop the |
5631b90
to
189abc0
Compare
Done |
@jasl I've noticed that RuboCop wasn't linting specs anymore so I fixed, see also CocoaPods/shared#11 |
Have discussed at #669 (comment)
This PR includes
In future: