Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPM: allow pod specs to declare Swift Package Manager dependencies with spm_dependency #743

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SPM: allow pod specs to declare Swift Package Manager dependencies with spm_dependency #743

wants to merge 1 commit into from
+171 −0

Conversation

mfazekas
Copy link

@mfazekas mfazekas commented Jun 15, 2023 •
edited
Loading

Implements: CocoaPods/CocoaPods#11942

See also: CocoaPods/CocoaPods#11953
First draft.

Note that I've implemented the keyword argument syntax:

spec.spm_dependency(
   :url => 'https://github.com/apple/swift-atomics.git',
   :requirement' => {:kind => 'upToNextMajorVersion',  :minimumVersion => '1.1.0'},
   :products' => ['Atomics']
)

But maybe using positional arguments would be better:

spec.spm_dependency(
   'https://github.com/apple/swift-atomics.git',
   {:kind => 'upToNextMajorVersion',  :minimumVersion => '1.1.0'},
   ['Atomics']
)

This was referenced Jun 15, 2023
Open
Open
@dnkoutso dnkoutso added this to the 1.13.0 milestone Jun 27, 2023
@mfazekas mfazekas force-pushed the podspec-spm branch 2 times, most recently from 8252a3c to 08554b4 Compare July 5, 2023 20:02
@dnkoutso dnkoutso modified the milestones: 1.13.0, 1.14.0 Sep 22, 2023
@mfazekas mfazekas mentioned this pull request Oct 26, 2023
Open
Archish27
Archish27 approved these changes Jan 18, 2024
View reviewed changes
Copy link

@Archish27 Archish27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Super Awesome, Can someone please check & get this merged?

@krishnkishore
Copy link

Is there a plan to merge and release this soon?

@bensonarafat
Copy link

Pls, when can this be merge soon

@zhu-xiaowei
Copy link

This is a very useful feature for developers using the CocoaPods managed project. Looking forward to merging soon.

@renanyoy
Copy link

renanyoy commented Mar 15, 2024 •
edited
Loading

what's the status of this PR ? is it available in cocoapod 1.14.3 ? is there still someone working on cocoapod ?

@eleazar0425
Copy link

Is this getting merged soon?

@Dunedubby
Copy link

Any update with getting this merged?

@zeeshanmakeen
Copy link

Any news about getting this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaherKSantina MaherKSantina MaherKSantina approved these changes

@Archish27 Archish27 Archish27 approved these changes

@Diego5529 Diego5529 Diego5529 approved these changes

@krishnkishore krishnkishore krishnkishore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.