Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMStore 0.4.3 #9311

Closed
wants to merge 1 commit into from
Closed

RMStore 0.4.3 #9311

wants to merge 1 commit into from

Conversation

hpique
Copy link
Contributor

@hpique hpique commented Mar 16, 2014

No description provided.

@kylef
Copy link
Contributor

kylef commented Mar 16, 2014

https://travis-ci.org/CocoaPods/Specs/builds/20884241#L198

Also, why don't you depend on the OpenSSL pod instead of creating a duplicate in a submodule?

@hpique
Copy link
Contributor Author

hpique commented Mar 16, 2014

That was fast. Thanks @kylef.

Can it be that something changed in the way platform is interpreted or validated? This was not failing before.

In my case, the pod is compatible with iOS 5.0 or higher, but there is a subspec that is only compatible with iOS 7. How can I express that now?

Regarding OpenSSL, that pod includes binaries, and I prefer to control the binaries that are shipped with my pod due to security concerns.

@hpique
Copy link
Contributor Author

hpique commented Mar 16, 2014

I should add that so far this podspec was behaving exactly as (I) expected. Projects who targeted iOS 7 got all subpecs. Project who targeted up to iOS 5 and iOS 6 didn't get the AppReceiptVerificator subpec.

@keith
Copy link
Member

keith commented Mar 18, 2014

What's the deal here?

@kylef
Copy link
Contributor

kylef commented Mar 18, 2014

I'm not entirely sure about the platform stuff.

@hpique I don't understand why the OpenSSL spec is a static library. Would it make sense to update the OpenSSL spec so it downloads the source and builds it?

Having two OpenSSLs (the real spec and this subspec) would result in issues when someone uses this spec and a spec that depends on the real OpenSSL. Duplicate symbols when linking. This would go away if a user manually used your subspecs and didn't include the OpenSSL subspec, however this isn't clear to most of users.

@hpique
Copy link
Contributor Author

hpique commented Mar 19, 2014

@Keithbsmiley Apparently the platform behavior or validation changed. See my previous two comments.

@kylef Yes, that's why I put OpenSSL as a subspec.

Agreed, it would be better for everyone to have an OpenSSL pod that downloads the source and builds it. I'm not sure if that's possible, though. We would have to translate this script into a pod. Maybe we should move the discussion about OpenSSL somewhere else?

@chrisballinger
Copy link
Contributor

I am also interested in a standardized way to include C libraries that depend on configure scripts with Cocoapods. Right now it looks like our only options are to include precompiled static libraries, but for the security reasons @hpique mentioned, we would like to avoid that.

@keith
Copy link
Member

keith commented Mar 25, 2014

Reopen if needed. All other discussion should probably be elsewhere about this stuff though.

@keith keith closed this Mar 25, 2014
@hpique
Copy link
Contributor Author

hpique commented Mar 25, 2014

Posted an issue in the CocoaPods repo.

@keith
Copy link
Member

keith commented Mar 25, 2014

👍

@kylef
Copy link
Contributor

kylef commented May 5, 2014

@hpique As of #11384, OpenSSL is now pulling from the real source. 👍

@hpique
Copy link
Contributor Author

hpique commented May 6, 2014

Thanks for letting me know @kylef! I'll update the podspec this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants