Update last known SDKs to iOS 12 etc. #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2018
|
@segiddins does this happen via the build settings update or separately as in this PR? |
|
separately, as in this PR |
segiddins
approved these changes
Sep 17, 2018
dnkoutso
reviewed
Sep 17, 2018
CHANGELOG.md
Outdated
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| ##### Enhancements | |||
|
|
|||
| * None. | |||
| * Update LAST_KNOWN_IOS_SDK to 11.3 | |||
There was a problem hiding this comment.
this is incorrect. Must be 12.0 and also nit to wrap LAST_KNOWN_IOS_SDK with backticks
There was a problem hiding this comment.
its also incorrect in a sense that this PR is actually updating all platform LAST_KNOWN_SDK value.
There was a problem hiding this comment.
Gah, you caught me copy-pasta’ing #564. 😊 I’ll fix that.
dnkoutso
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
LAST_KNOWN_*_SDKconstants to this year’s latest and greatest.