Add support to parse OTHER_LDFLAGS arg files using '@' #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
add_support_ldflags_arg_files
branch
2 times, most recently
from
0d83208
to
888e93f
Compare
segiddins
approved these changes
May 26, 2021
amorde
approved these changes
May 26, 2021
| @@ -123,12 +169,15 @@ | |||
| flags << '-lxml2.2.7.3' | |||
| flags << '-l "Pods-AFNetworking iOS Example-AFNetworking"' | |||
| flags << '-l"Pods-AFNetworking iOS Example-AFNetworking"' | |||
| flags << '@"${PODS_ROOT}/Target Support Files/other_ldflags"' | |||
| flags << '@ "${PODS_ROOT}/Target Support Files/other_ldflags"' | |||
There was a problem hiding this comment.
is there a test case covering a space between @ and the quoted file path?
There was a problem hiding this comment.
I believe so yes, right above
dnkoutso
force-pushed
the
add_support_ldflags_arg_files
branch
from
888e93f
to
d83ee02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.