Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

584 dexbot installer #618

Closed
wants to merge 69 commits into from
Closed

Conversation

dominic22
Copy link

Added dexbot installer and integrated it into the appveyor build process. Furthermore the new icon of dexbot and an application icon were added.

@dominic22 dominic22 removed their assignment Jun 13, 2019
appveyor.yml Outdated Show resolved Hide resolved
dexbot/__init__.py Outdated Show resolved Hide resolved
dexbot/__init__.py Outdated Show resolved Hide resolved
appveyor.yml Show resolved Hide resolved
appveyor.yml Show resolved Hide resolved
appveyor.yml Outdated Show resolved Hide resolved
appveyor.yml Outdated Show resolved Hide resolved
@bitphage
Copy link
Collaborator

Binary files to remove from history to prevent unneeded repo growth:

installer/windows/bundle/prerequisites/python-3.7.3.exe
installer/windows/msi/DEXBot.exe

@bitphage
Copy link
Collaborator

bitphage commented Jun 27, 2019

Hmm, looks like installer/windows/bundle/prerequisites/python-3.7.3.exe is listed inside installer/windows/bundle/bundle.wixproj as a requirement (it's needed to build the installer). It's a generally bad idea to put such binaries in repo, we should consider moving this binary outside and probably download it at build time.

@bitphage bitphage mentioned this pull request Jul 7, 2019
@bitphage
Copy link
Collaborator

bitphage commented Jul 7, 2019

#626

@joelvai joelvai closed this Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants