Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order reconstruction #727

Merged
merged 10 commits into from
Mar 20, 2020
Merged

Fix order reconstruction #727

merged 10 commits into from
Mar 20, 2020

Commits on Mar 12, 2020

  1. Add pre-commit hooks 

    Hooks ensure proper formatting and linting before commiting
    @bitphage
    bitphage committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    082d9fa View commit details
    Browse the repository at this point in the history

  2. Add note on installing pre-commit hooks

    @bitphage
    bitphage committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    391a701 View commit details
    Browse the repository at this point in the history

  3. Reformat code with black & isort 

    No pep8 fixes, just reformat.

Closes: Codaone#716
    @bitphage
    bitphage committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    4dbb9f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2020

  1. Update bitshares libraries 

    Closes: Codaone#692
    @bitphage
    bitphage committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    a2a7e18 View commit details
    Browse the repository at this point in the history

  2. Add switch to disable fallback logic in SO

    @bitphage
    bitphage committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    58cc48d View commit details
    Browse the repository at this point in the history

  3. Fix operational depth when fallback logic is off

    @bitphage
    bitphage committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    6d57aa5 View commit details
    Browse the repository at this point in the history

  4. Close spread before replacing virtual orders with real

    @bitphage
    bitphage committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    31908d0 View commit details
    Browse the repository at this point in the history

  5. Add workaround to fix some tests 

    Problem described here Codaone#575
Workaround is to use approx value for spread comparison accepting a
slight error.
    @bitphage
    bitphage committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    00c9636 View commit details
    Browse the repository at this point in the history

  6. Append orderid when reconstructing order data

    @bitphage
    bitphage committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    eb95805 View commit details
    Browse the repository at this point in the history

  7. Fix proper order reconstruction 

    calculate_order_data() should reconstruct buy/sell orders differently to
achive same result as return from the node (without inversion)
    @bitphage
    bitphage committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    b4290cc View commit details
    Browse the repository at this point in the history