Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customize popout fade timeout #133

Merged
merged 6 commits into from
Apr 17, 2017
Merged

customize popout fade timeout #133

merged 6 commits into from
Apr 17, 2017

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Apr 17, 2017 •
edited
Loading

Supersedes #109
Fixes #101

Let's the user control the fade timeout for the message.

  • rebase existing code on master
  • tidy up diff to simplify review
  • indicate fade delay is a value in seconds

@shiftkey shiftkey mentioned this pull request Apr 17, 2017
Closed
hnrkndrssn
hnrkndrssn approved these changes Apr 17, 2017
View reviewed changes
Copy link
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Just one minor thing, changing the value requires a restart of the app, but I guess there's not much we can do about that as the settings are read at startup?

@hnrkndrssn
Copy link
Contributor

Relates to #101

@shiftkey
Copy link
Member Author

Just one minor thing, changing the value requires a restart of the app, but I guess there's not much we can do about that as the settings are read at startup?

Yeah, and I'm okay with that. If someone wants to polish that we can revisit it later.

@hnrkndrssn
Copy link
Contributor

👍

@hnrkndrssn hnrkndrssn merged commit 4d12250 into master Apr 17, 2017
@hnrkndrssn hnrkndrssn deleted the rework-popout-feature branch April 17, 2017 12:36
@HowardWolosky HowardWolosky mentioned this pull request Oct 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hnrkndrssn hnrkndrssn hnrkndrssn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shiftkey @hnrkndrssn