Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Schnorr signature #258

Open
kseo opened this issue Jun 22, 2018 · 7 comments
Open

Introduce Schnorr signature #258

kseo opened this issue Jun 22, 2018 · 7 comments

Comments

@kseo
Copy link
Member

kseo commented Jun 22, 2018

It's ready now.

@kseo
Copy link
Member Author

kseo commented Jul 10, 2018

Some preparation patches were landed: 6359ab0, 9a78f45, c4f49a8, 37a34b8, 418d472, 94ef1e6, 0990b70, 6e78e95

@kseo kseo changed the title Replace ECDSA with Schnorr signature Introduce Schnorr signature Jul 10, 2018
@kseo kseo assigned hyunsikjeong and unassigned kseo Oct 2, 2018
@hyunsikjeong
Copy link
Contributor

hyunsikjeong commented Oct 4, 2018

To-do

  • Read the issues in libsecp256k1 which are related to Schnorr signature.
  • Make a demo for Schnorr signature.
  • Implement Schnorr signature in the CodeChain primitives and the SDK.

@hyunsikjeong
Copy link
Contributor

Finished working on the primitives.

@hyunsikjeong
Copy link
Contributor

@hyunsikjeong
Copy link
Contributor

Might need to change the code of libsecp256k1. See https://github.com/sipa/bips/blob/bip-schnorr/bip-schnorr.mediawiki#cite_note-4, the current code uses the option 2.

@sgkim126
Copy link
Contributor

@jhs7jhs What is the current status of this issue? Is there something to do?

@hyunsikjeong
Copy link
Contributor

hyunsikjeong commented Nov 22, 2018

@sgkim126 Currently the basic implementation is finished, but it's based on the experimental part of the old version of the bitcoin library, so it is quite dangerous to merge. Also, MuSig signing is not supported yet and needs to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants