Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ECDSA with Schnorr signature #264

Closed
wants to merge 2 commits into from
Closed

Replace ECDSA with Schnorr signature #264

wants to merge 2 commits into from

Conversation

kseo
Copy link
Member

@kseo kseo commented Jun 23, 2018

Fix #258

@kseo kseo requested a review from sgkim126 June 23, 2018 06:05
sgkim126
sgkim126 reviewed Jun 23, 2018
View reviewed changes
Copy link
Contributor

@sgkim126 sgkim126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I think we should wait to merge it until SDK prepares schnorr signature.

@kseo
Copy link
Member Author

kseo commented Jun 23, 2018

@sgkim126 Okay I will add tests in the mean time.

@kseo
Copy link
Member Author

kseo commented Jun 23, 2018

I updated the wiki: https://github.com/CodeChain-io/codechain/wiki/Digital-Signature

@kseo kseo added the key label Jun 27, 2018
sgkim126
sgkim126 requested changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@sgkim126 sgkim126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's postpone it until we build a stable schnorr library.

@kseo
Copy link
Member Author

kseo commented Jul 3, 2018

Let's revisit this issue later.

@kseo kseo closed this Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgkim126 sgkim126 sgkim126 requested changes

Assignees
No one assigned
Labels
key
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kseo @sgkim126