Add FAIL, SUCCESS opcode #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgkim126
requested review from
joojis and
remagpie
and removed request for
joojis
|
@junbeomlee You need to sign the CLA. https://www.clahub.com/agreements/CodeChain-io/codechain |
remagpie
requested changes
Jul 11, 2018
vm/Cargo.toml
Outdated
| @@ -7,7 +7,7 @@ authors = ["CodeChain Team <codechain@kodebox.io>"] | |||
|
|
|||
| [dependencies] | |||
| codechain-crypto = { path = "../crypto" } | |||
| codechain-key = { path = "../key" } | |||
| codechain-key = { path = "../key"} | |||
There was a problem hiding this comment.
It doesn't need to be changed.
|
@kseo Thank you, i signed it!! |
remagpie
requested changes
Jul 12, 2018
vm/src/executor.rs
Outdated
| @@ -36,6 +36,7 @@ impl Default for Config { | |||
|
|
|||
| #[derive(Debug, PartialEq)] | |||
| pub enum ScriptResult { | |||
| Success, | |||
There was a problem hiding this comment.
We don't need additional result type. Unlocked means Success.
vm/src/executor.rs
Outdated
| @@ -161,6 +162,8 @@ pub fn execute( | |||
| match &script[pc] { | |||
| Instruction::Nop => {} | |||
| Instruction::Burn => return Ok(ScriptResult::Burnt), | |||
| Instruction::Success => return Ok(ScriptResult::Success), | |||
There was a problem hiding this comment.
Return Unlocked instead of Success.
remagpie
previously approved these changes
Jul 12, 2018
remagpie
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #283