Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JSON RPC net_getPort #536

Merged
merged 2 commits into from
Aug 4, 2018
Merged

Implement JSON RPC net_getPort #536

merged 2 commits into from
Aug 4, 2018

Conversation

foriequal0
Copy link
Contributor

@foriequal0 foriequal0 commented Aug 4, 2018 •
edited
Loading

@majecty majecty requested review from sgkim126 and majecty August 4, 2018 03:52
@kseo
Copy link
Member

kseo commented Aug 4, 2018

@foriequal0 Please sign the CLA.

kseo
kseo requested changes Aug 4, 2018
View reviewed changes
Copy link
Member

@kseo kseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the first patch is necessary because address is an abbreviation of socket_address.

@foriequal0
Copy link
Contributor Author

Okay. Should I append a commit or rewrite the history?

@foriequal0 foriequal0 force-pushed the feature/rpc-get-port branch from e083d33 to c5e7a3b Compare August 4, 2018 07:13
kseo
kseo approved these changes Aug 4, 2018
View reviewed changes
Copy link
Member

@kseo kseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@kseo kseo merged commit 480994f into CodeChain-io:master Aug 4, 2018
@foriequal0 foriequal0 mentioned this pull request Aug 4, 2018
Merged
@majecty majecty mentioned this pull request Aug 4, 2018
Closed
This was referenced Sep 15, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kseo kseo kseo approved these changes

@sgkim126 sgkim126 Awaiting requested review from sgkim126

@majecty majecty Awaiting requested review from majecty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foriequal0 @kseo