Change unit test of stratum to use unused ports #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunsikjeong
force-pushed
the
fix-stratum-unit-test
branch
from
48f7685 to
e1c0659
Compare
remagpie
reviewed
Nov 30, 2018
hyunsikjeong
force-pushed
the
fix-stratum-unit-test
branch
from
e1c0659 to
de185bd
Compare
sgkim126
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #457
This design is inevitable, because if ranges are overlapping each other, then there will be a race condition while finding the port due to parallel testing, so each test case will be able to choose the same port.
If there's a better way, please let me know.