Merge pull request #1251 from CodeCrowCorp/dev

Fix: testing null video elements
CodeCrowCorp · May 15, 2024 · 2b25b89 · 2b25b89
2 parents bbd8055 + 8be65ca
commit 2b25b89
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/lib/WHIPClient.ts b/src/lib/WHIPClient.ts
@@ -154,7 +154,9 @@ export default class WHIPClient extends EventTarget {
 		// })
 		this.peerConnection.close()
 		this.localStream?.getTracks().forEach((track) => track.stop())
-		this.videoElement.srcObject = null
+		if (this.videoElement) {
+			this.videoElement.srcObject = null
+		}
 		this.dispatchEvent(new CustomEvent(`localStreamStopped-${this.trackType}`))
 		console.log('Disconnected')
 	}

diff --git a/src/lib/components/Channel/Stream/VideoItem.svelte b/src/lib/components/Channel/Stream/VideoItem.svelte
@@ -436,8 +436,7 @@
 						class="rounded-md w-full h-full"
 						allow="accelerometer; gyroscope; autoplay; encrypted-media; picture-in-picture; fullscreen;" />
 				</div>
-			{/if}
-			{#if !iframeUrl}
+			{:else}
 				<video
 					bind:this={screen_element}
 					id={`screen-${video._id}`}