Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Google fonts #68

Merged
merged 2 commits into from
Sep 18, 2020
Merged

[Fix] Google fonts #68

merged 2 commits into from
Sep 18, 2020

Conversation

kilemensi
Copy link
Member

Description

Seems like Nextjs/React have issue with onLoad event on link and hence the media hack for loading fonts was not working. This PR address the issue by using next-google-fonts package until this issue is resolved in Nextjs/React.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

S

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kilemensi kilemensi added the bug Something isn't working label Sep 17, 2020
@kilemensi kilemensi self-assigned this Sep 17, 2020
@kilemensi kilemensi requested a review from nerdlet September 17, 2020 11:57
@vercel
Copy link

vercel bot commented Sep 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/codeforafrica/promisetracker/hjohjjiyl
✅ Preview: https://promisetracker-git-fix-googlefonts.codeforafrica.vercel.app

@kilemensi kilemensi requested a review from KobbyMmo September 17, 2020 11:57
@kilemensi kilemensi merged commit 9525046 into main Sep 18, 2020
@kilemensi kilemensi deleted the fix/google_fonts branch September 18, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant