Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robots Generator #702

Merged
merged 114 commits into from
Jun 21, 2024
Merged

Robots Generator #702

merged 114 commits into from
Jun 21, 2024

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented May 28, 2024

Description

This PR introduces a new app Robots Generator

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

image
image
image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
kelvinkipruto and others added 15 commits June 3, 2024 16:53
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
…enerator

Add ability to parse robots.txt files
@m453h

This comment was marked as resolved.

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀


Screenshot 2024-06-20 at 16 00 47

Stick to Blue, Red and Black:

  1. Reset - Red
  2. Back - Blue, same styling as previous tabs i.e. outlined
  3. Download - Black (if you think Copy to Clipboard is more important)
  4. Copy to Clipboard - Blue

apps/roboshield/next.config.mjs Outdated Show resolved Hide resolved
apps/roboshield/src/components/Timepicker/Timepicker.tsx Outdated Show resolved Hide resolved
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@m453h
Copy link
Contributor

m453h commented Jun 20, 2024

🚀

Screenshot 2024-06-20 at 16 00 47 Stick to Blue, Red and Black:
  1. Reset - Red
  2. Back - Blue, same styling as previous tabs i.e. outlined
  3. Download - Black (if you think Copy to Clipboard is more important)
  4. Copy to Clipboard - Blue

With these adjustments the back button does feel a bit left out when in mobile version, what are your view @kilemensi / @kelvinkipruto

Large screens:
Screenshot 2024-06-20 at 16 40 46

Mobile:
Screenshot 2024-06-20 at 16 38 25

…ponent

Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@kilemensi
Copy link
Member

kilemensi commented Jun 20, 2024

What happened to the blue border around it @m453h? I thought we were using outlined variant.

@kilemensi
Copy link
Member

PS: Reset should come after Back even in mobile... may be there should still be a gap between the first 3 and Reset even in mobile @m453h

@m453h
Copy link
Contributor

m453h commented Jun 20, 2024

What happened to the blue border around it @m453h? I thought we were using outlined variant.

@kilemensi I was thinking of adopting a consistent style from previous section(s), i.e. the back button(s) had no border, should I update the rest of the sections as well to this variant ?

@kilemensi
Copy link
Member

I was thinking of adopting a consistent style from previous section(s), i.e. the back button(s) had no border

Cool... then lets leave it as is @m453h . We can always revisit it if other folks find an issue with it.

@kelvinkipruto kelvinkipruto added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit f13b7f6 Jun 21, 2024
4 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/robots-generator branch June 21, 2024 07:11
@TheMikeyRoss
Copy link

Hi,

How did you guys resolve the warning as in vercel/next.js#65161 (comment)

@kelvinkipruto
Copy link
Contributor Author

@TheMikeyRoss We resolved it by upgrading NextJS to 14.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants