Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: clean up mapbox references #864

Closed
6 tasks
nlebovits opened this issue Aug 7, 2024 · 3 comments
Closed
6 tasks

Task: clean up mapbox references #864

nlebovits opened this issue Aug 7, 2024 · 3 comments
Assignees

Comments

@nlebovits
Copy link
Collaborator

Describe the task

We have several small, related mapbox-gl issues that can be addressed in one go:

  • We need to replace the mapbox geocoder with maptiler
  • We need to confirm that the Mapbox key has been fully moved to an env var
  • We need to update mapbox-gl to the latest version

Acceptance Criteria

  • Remove and replace @mapbox/mapbox-gl-geocoder with a solution that uses the Maptiler API
  • Make sure all references to the Mapbox key have been moved to an env var
  • Upgrade mapbox-gl to the latest version
  • Fix all breaking changes
  • Run npm run build in the local env to verify that all breaking changes have been addressed
  • Ensure no functionality loss

Additional context

Upgrading from v3.2.0 to v3.5.2 will cause breaking changes in these two files (and possibly more):

src/components/PropertyMap.tsx
src/components/MapLegendControl/MapLegend.tsx

Breaking changes include this import statement in MapLegend.tsx: import { ExpressionName } from 'mapbox-gl'.
As of v3.5.2, ExpressionName has been removed from mapbox-gl.

Another breaking change is mapboxgl: mapboxgl in PropertyMap.tsx due to updates to the namespace mapboxgl.

Resources

Copy link

This issue has been marked as stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Oct 27, 2024
@CodeWritingCow CodeWritingCow self-assigned this Oct 30, 2024
@nlebovits
Copy link
Collaborator Author

Bumping this in priority.

Currently, my old Mapbox token is in config.ts. This is obviously a problem. Someone ran up $50 in raster tile queries on it recently--that's no good. I shut the key down, but for the sake of the future, we need to remove mapbox entirely from the equation, since we're no longer relying on it, make sure all relevant local vars are defined locally and the docs reflect that, and make sure to fix any breaking changes.

@nlebovits
Copy link
Collaborator Author

closed by #1003, minus the mapbox key--it's a small fix that I'll handle myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants