Replace mapbox geocoding control with maptile geocoding control #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates several nodejs dependencies to their latest versions with `npm audit fix` in order to pass the precommit hook.
Included @maptiler/geocoding-control in dependencies as a replacement for @mapbox/mapbox-gl-geocoder.
Replaced Mapbox Geocoder with MapTiler GeocodingControl for address lookup and map navigation.
The original filter condition yields seems to yield no results.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HeyZoos
commented
Nov 16, 2024
Comment on lines
+50
to
+57
| "@typescript-eslint/eslint-plugin": "^7.16.1", | ||
| "@typescript-eslint/parser": "^7.16.1", | ||
| "eslint": "^8.56.0", | ||
| "eslint-config-next": "^14.2.5", | ||
| "eslint-config-prettier": "^9.1.0", | ||
| "eslint-plugin-custom-rules": "file:./eslint-plugin-custom-rules", | ||
| "eslint-plugin-prettier": "^5.0.0", | ||
| "eslint-plugin-react": "^7.34.4", |
There was a problem hiding this comment.
ESLint is alphabetizing the imports
HeyZoos
commented
Nov 16, 2024
Comment on lines
-28
to
+27
| switch (name as ExpressionName) { | ||
| switch (name as string) { |
There was a problem hiding this comment.
There is an Expression type with a match operator. But I couldn't figure out how to use it the way we did originally. Given the this is just for TypeScript, I didn't think it was a blocker.
HeyZoos
commented
Nov 16, 2024
src/components/PropertyMap.tsx
Outdated
Comment on lines
423
to
425
| filter={(feature: any) => { | ||
| return feature.context.some((i: any) => { | ||
| return i.text.includes("Philadelphia"); |
There was a problem hiding this comment.
There is a Feature type, but it's missing the context in the TypeScript definition for some reason. It's confusing because it's present in the docs. So maybe the TS definitions are just out of date.
HeyZoos
commented
Nov 16, 2024
src/components/PropertyMap.tsx
Outdated
Comment on lines
423
to
425
| filter={(feature: any) => { | ||
| return feature.context.some((i: any) => { | ||
| return i.text.includes("Philadelphia"); |
There was a problem hiding this comment.
The original filter was not returning any results:
return (
(i.id.split('.').shift() === 'place' &&
i.text === 'Philadelphia') ||
(i.id.split('.').shift() === 'district' &&
i.text === 'Philadelphia County')
);Maybe the API response body changed, but it seemed too specific to match any of the feature context objects. Here's one for example:
"context": [
{
"ref": "oa:../oa-us/us/pa/philadelphia-county/eac8fa1be5800983",
"country_code": "us",
"id": "postal_code.3238707",
"text": "19145-2906",
"text_en": "19145-2906"
},
{
"ref": "osm:n158288891",
"country_code": "us",
"id": "place.4391290",
"text": "Girard Estates",
"wikidata": "Q5564154",
"kind": "place",
"osm:place_type": "neighbourhood",
"text_en": "Girard Estates"
},
{
"ref": "osm:r7962835",
"country_code": "us",
"id": "neighbourhood.50999",
"text": "South Philadelphia",
"wikidata": "Q7568214",
"kind": "admin_area",
"language": "en",
"text_en": "South Philadelphia",
"language_en": "en"
},
{
"ref": "osm:r188022",
"country_code": "us",
"id": "municipality.196053",
"text": "Philadelphia",
"wikidata": "Q1345",
"kind": "admin_area",
"language": "en",
"text_en": "Philadelphia",
"language_en": "en"
},
{
"ref": "osm:r417845",
"country_code": "us",
"id": "county.16952",
"text": "Philadelphia",
"wikidata": "Q496900",
"kind": "admin_area",
"text_en": "Philadelphia"
},
{
"ref": "osm:r162109",
"country_code": "us",
"id": "region.3014",
"text": "Pennsylvania",
"wikidata": "Q1400",
"kind": "admin_area",
"language": "en",
"text_en": "Pennsylvania",
"language_en": "en"
},
{
"ref": "osm:r148838",
"country_code": "us",
"id": "country.1223",
"text": "United States",
"wikidata": "Q30",
"kind": "admin_area",
"language": "en",
"text_en": "United States",
"language_en": "en"
},
{
"ref": "osm:n36966063",
"country_code": "",
"id": "continental_marine.4",
"text": "North America",
"wikidata": "Q49",
"categories": [
"continent"
],
"language": "en",
"osm:tags": {
"population": "528720588",
"wikipedia": "en:North America",
"place": "continent",
"sqkm": "24709000"
},
"text_en": "North America",
"language_en": "en"
}
]
This was referenced Nov 18, 2024
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Mapbox dependencies by replacing Mapbox Geocoder with MapTiler GeocodingControl, restoring the Geocoding Control functionality Updated package-lock.json dependencies to remove mapbox-gl dependencies and pass precommit hook.
https://docs.maptiler.com/react/maplibre-gl-js/geocoding-control/
Fixes #864