Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 646 change saved btn icon #693

Conversation

zheyichn
Copy link
Contributor

@zheyichn zheyichn commented Jun 12, 2024

  • Changed the bookmark icon for saving a property to a check icon.
  • Screenshoots:
646-updated-icon
646-icon-test-local.mov

Closes #646

Copy link

vercel bot commented Jun 12, 2024

@zheyichn is attempting to deploy a commit to the Clean and Green Philly Team on Vercel.

A member of the Team first needs to authorize it.

@zheyichn zheyichn changed the title Zheyichn/646 change saved btn icon Fix issue 646 change saved btn icon Jun 12, 2024
@zheyichn
Copy link
Contributor Author

Hi @CodeWritingCow, I don't have write access yet and Vercel checks failed, pls let me know if the pr flow above looks right and how to proceeed, thx.

@CodeWritingCow
Copy link
Collaborator

Hi @zheyichn I've been seeing this Vercel check failure in other PRs, too. GitHub is trying to deploy your PR to a testing environment in Vercel. However, only someone with admin rights can authorize that deployment. (I tried authorizing it but didn't work.) As a temporary workaround, I'm testing your code in my local environment.

Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zheyichn, your PR looks good. I watched your screen recording and was able to replicate the new button functionality locally. I'll merge the PR into staging branch. Once we're ready to deploy a new release into production, @nlebovits will make a PR from staging into main branch. Thanks for your work!

@CodeWritingCow CodeWritingCow merged commit 7269200 into CodeForPhilly:staging Jun 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants