Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 660: Add aria label to IconLink #702

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Issue 660: Add aria label to IconLink #702

merged 1 commit into from
Jun 24, 2024

Conversation

KenMain5
Copy link
Contributor

Refactored the value of aria-current from "true" to "page" as the description requested.

Closes #660

@vercel Vercel
Copy link

vercel bot commented Jun 21, 2024

@KenMain5 is attempting to deploy a commit to the Clean and Green Philly Team on Vercel.

A member of the Team first needs to authorize it.

@KenMain5 KenMain5 mentioned this pull request Jun 21, 2024
Closed
CodeWritingCow
CodeWritingCow approved these changes Jun 23, 2024
View reviewed changes
Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KenMain5, PR looks good. I checked aria-current on the four pages. Its value is set to page as expected. Thanks for contributing!

@CodeWritingCow
Copy link
Collaborator

Hi @marvieqa @bacitracin can you take a quick look at this a11y-related PR? Thank you!

@bacitracin
Copy link
Collaborator

Hey @KenMain5 I haven't pulled down this branch and tested it yet, but it seems straightforward enough and @CodeWritingCow tested it. Had a question though.

aria-current is currently used in both the IconLink and ThemeButton components. This PR fixes the issue in Iconlink, but the title of the PR mentions ThemeButtonLink. Is the PR title just out of date or incorrect?

@KenMain5
Copy link
Contributor Author

Hey @KenMain5 I haven't pulled down this branch and tested it yet, but it seems straightforward enough and @CodeWritingCow tested it. Had a question though.

aria-current is currently used in both the IconLink and ThemeButton components. This PR fixes the issue in Iconlink, but the title of the PR mentions ThemeButtonLink. Is the PR title just out of date or incorrect?

@KenMain5 KenMain5 closed this Jun 23, 2024
@KenMain5 KenMain5 reopened this Jun 23, 2024
@KenMain5
Copy link
Contributor Author

@bacitracin that's my mb! yes yes, the PR title is incorrect but the code fixes the correct issue 660

@CodeWritingCow CodeWritingCow changed the title Issue 660: Add aria label to ThemeButtonLink Issue 660: Add aria label to IconLink Jun 24, 2024
@CodeWritingCow
Copy link
Collaborator

@bacitracin thanks for catching the PR title mistake. I've fixed the title.

@CodeWritingCow CodeWritingCow merged commit 5a3c8d3 into CodeForPhilly:staging Jun 24, 2024
2 of 3 checks passed
@CodeWritingCow CodeWritingCow added the A11y Accessibility label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeWritingCow CodeWritingCow CodeWritingCow approved these changes

@bacitracin bacitracin bacitracin approved these changes

@marvieqa marvieqa Awaiting requested review from marvieqa

Assignees
No one assigned
Labels
A11y Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KenMain5 @CodeWritingCow @bacitracin