Lebovits/issu643 add frontend formatting check #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.github/workflows/pr_checks.yaml
Outdated
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
Hi @nlebovits why is the PR downgrading actions/checkout from v4 to v3?
There was a problem hiding this comment.
@CodeWritingCow good catch! sloppy chatgpt hallucinations lol
There was a problem hiding this comment.
will fix in a new commit + check the other PR for backend work to do the same
There was a problem hiding this comment.
@CodeWritingCow going to add a dependabot.yml to keep these up to date. see #757
|
Hi @nlebovits the PR has a merge conflict. Can you resolve it? Thanks! |
nlebovits
added a commit
that referenced
this pull request
Jul 18, 2024
* make rake icon white under drak mode * use default color theme * use ButtonText for street view icon * add dependabot yml to keep ghactions, npm. and pip dependencies up to date * get pr_checks_backend.yml working (#756) * Set up pr_checks_backend.yml to run black formatter * Also run flake8 linting * Check if main docker container builds correctly * Check if postgres container runs correctly * update vscode/settings.json to match formatting + linting * Lebovits/issu643 add frontend formatting check (#752) * add formatting + linting checks to front end workflows * have checks run on PRs to staging, not main * Lebovits/fix backend issues (#708) * Fix issue with pipfile creation in docker * Update + organize back end docs --------- Co-authored-by: klaus <zheyic@seas.upenn.edu> Co-authored-by: Gary Pang <gary.pang@gmail.com>
nlebovits
added a commit
that referenced
this pull request
Jul 18, 2024
* make rake icon white under drak mode * use default color theme * use ButtonText for street view icon * add dependabot yml to keep ghactions, npm. and pip dependencies up to date * get pr_checks_backend.yml working (#756) * Set up pr_checks_backend.yml to run black formatter * Also run flake8 linting * Check if main docker container builds correctly * Check if postgres container runs correctly * update vscode/settings.json to match formatting + linting * Lebovits/issu643 add frontend formatting check (#752) * add formatting + linting checks to front end workflows * have checks run on PRs to staging, not main * Lebovits/fix backend issues (#708) * Fix issue with pipfile creation in docker * Update + organize back end docs --------- Co-authored-by: klaus <zheyic@seas.upenn.edu> Co-authored-by: Gary Pang <gary.pang@gmail.com>
nlebovits
added a commit
that referenced
this pull request
Jul 18, 2024
* Merge staging to main (#760) * make rake icon white under drak mode * use default color theme * use ButtonText for street view icon * add dependabot yml to keep ghactions, npm. and pip dependencies up to date * get pr_checks_backend.yml working (#756) * Set up pr_checks_backend.yml to run black formatter * Also run flake8 linting * Check if main docker container builds correctly * Check if postgres container runs correctly * update vscode/settings.json to match formatting + linting * Lebovits/issu643 add frontend formatting check (#752) * add formatting + linting checks to front end workflows * have checks run on PRs to staging, not main * Lebovits/fix backend issues (#708) * Fix issue with pipfile creation in docker * Update + organize back end docs --------- Co-authored-by: klaus <zheyic@seas.upenn.edu> Co-authored-by: Gary Pang <gary.pang@gmail.com> * Staging (#768) * make rake icon white under drak mode * use default color theme * use ButtonText for street view icon * add dependabot yml to keep ghactions, npm. and pip dependencies up to date * get pr_checks_backend.yml working (#756) * Set up pr_checks_backend.yml to run black formatter * Also run flake8 linting * Check if main docker container builds correctly * Check if postgres container runs correctly * update vscode/settings.json to match formatting + linting * Lebovits/issu643 add frontend formatting check (#752) * add formatting + linting checks to front end workflows * have checks run on PRs to staging, not main * Lebovits/fix backend issues (#708) * Fix issue with pipfile creation in docker * Update + organize back end docs --------- Co-authored-by: klaus <zheyic@seas.upenn.edu> Co-authored-by: Gary Pang <gary.pang@gmail.com> * make rake icon white under drak mode * use default color theme --------- Co-authored-by: klaus <zheyic@seas.upenn.edu> Co-authored-by: Gary Pang <gary.pang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close issue #643 to add a formatting check for the front end on PR.