Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request 948: set up donation page #957

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

nlebovits
Copy link
Collaborator

addresses #948

Ideally, I'd like to embed the FundRazer donation widget, but was having issues getting it to play nicely with react. Maybe for someone else to do another time.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 2:08am

@github-actions github-actions bot requested a review from zigouras October 18, 2024 01:37
@nlebovits nlebovits changed the title skip precommit feature request 948: set up donation page Oct 18, 2024
@CodeWritingCow
Copy link
Collaborator

CodeWritingCow commented Oct 18, 2024

@nlebovits page looks great!

Desktop nav bar has the "donate" heart icon.
Screen Shot 2024-10-17 at 9 50 27 PM

However, mobile nav menu doesn't have it.
Screen Shot 2024-10-17 at 9 50 37 PM

Let's add it to the mobile nav menu too. Thanks!

Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add donate icon to mobile nav menu. I'll then approve the PR. Thanks!

Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlebovits mobile nav menu has the icon now. Thanks!

@CodeWritingCow
Copy link
Collaborator

One observation: I had to scroll down to see the icon. This is likely due to the mobile nav menu itself. Not sure if this hampers user experience, but we can address this in a separate ticket in the future.

Screen Shot 2024-10-17 at 10 11 49 PM

@nlebovits nlebovits merged commit 82166cf into staging Oct 18, 2024
5 checks passed
@nlebovits nlebovits deleted the lebovits/issu948-donate-page branch October 18, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants