Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix donate option not visible in mobile nav dropdown #985

Conversation

vinhyan
Copy link
Contributor

@vinhyan vinhyan commented Oct 29, 2024

Description

The mobile nav dropdown currently overflows, causing some items to be hidden and requiring users to scroll to view all options. This PR adjusts the max-height of the mobile nav dropdown, ensuring all items are fully visible without scrolling.

Fixes #976

fixed-clean-green-philly-issue976.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 11:49pm

@CodeWritingCow
Copy link
Collaborator

Hello @vinhyan, I switched the target branch from main to staging. That is our project's practice for submitting most PRs (except for those deploying to the live site). Thanks!

@vinhyan
Copy link
Contributor Author

vinhyan commented Oct 30, 2024

Oh shoot sorry I overlooked that. Thank you @CodeWritingCow! :)

Copy link
Collaborator

@bacitracin bacitracin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bacitracin bacitracin merged commit 6133dc6 into CodeForPhilly:staging Oct 31, 2024
5 checks passed
@vinhyan
Copy link
Contributor Author

vinhyan commented Nov 1, 2024

Hi @bacitracin! Sorry for bothering you again but would you be able to add the hacktoberfest label to this PR?

@bacitracin
Copy link
Collaborator

@vinhyan done!

@vinhyan vinhyan deleted the vinhyan/976-fix-donate-option-not-visible-in-dropdown-mobile branch November 1, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile nav - Donate option is not visible in dropdown
4 participants