Fixed activity to use font awesome spinner. #39
Merged
+50
−373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Dropped jquery dependency. * Added AMD wrapper. * Support custom active/inactive classes (for use without font awesome).
This was referenced Nov 27, 2013
Closed
|
Just what I had planned, looks great @acornejo. Great job! |
hfjallemark
pushed a commit
that referenced
this pull request
Nov 28, 2013
Fixed activity to use font awesome spinner.
|
I really like this simple idea. |
| }; | ||
| } | ||
| $(s).remove(); | ||
| var defaultOptions = { |
There was a problem hiding this comment.
It would be cool to set these options from outside,
There was a problem hiding this comment.
fairly easy to do a pullRequest to add that functionality by making defaultOptions accessible from the outside (say, ko.bindingHandlers.activity.defaultOptions).
There was a problem hiding this comment.
Yeah, like we do in toastr. Send a PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version is much shorter than the original. It also works without font awesome, by allowing users to specify a custom element and class combination to use for signaling active and inactive states.
For instance:
This will insert a span container inside the button and apply class 'busy' when the button is active, and no classes when the button is not active.