Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group work by sprint #38

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Group work by sprint #38

merged 1 commit into from
Dec 5, 2023

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Nov 11, 2023

  • group and add headings showing sprint name
  • remove wonky details (which seems to expect to do this already but doesn't) from home page and link straight to module view with sprint

Fixes #26 Test on this view https://deploy-preview-38--cyf-pd.netlify.app/modules/fundamentals/

Scenario: view Sprint view on Module ✅
GIVEN I am on the PD Curriculum page
WHEN I click on a module (i.e Fundamentals)
THEN I can see all blocks organised per sprints

Scenario: Sprints should be shown in order ✅
GIVEN I am on a module page
WHEN I see the sprints
THEN they are in order from 1 to 4

Scenario: sprints should include all blocks related to it✅
GIVEN I am on a module page
WHEN I click on a sprint
THEN I can see the Prep blocks
AND the lessons blocks for that sprint

- group and add headings showing sprint name
- remove wonky details (which seems to expect to do this already but doesn't) from home page and link straight to module view with sprint
Copy link

netlify bot commented Nov 11, 2023

Deploy Preview for cyf-pd ready!

Name Link
🔨 Latest commit 9742bd7
🔍 Latest deploy log https://app.netlify.com/sites/cyf-pd/deploys/654f78faef721e0008f34301
😎 Deploy Preview https://deploy-preview-38--cyf-pd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (🟢 up 4 from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kfklein15 kfklein15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic.
Checked the fundamentals page on the PR:

  • links were working and showing the correct content
  • sprint grouping was done correctly

Sorry for the delay in approving it, not sure why I missed it.

@SallyMcGrath SallyMcGrath merged commit 1cf5b10 into main Dec 5, 2023
4 checks passed
@SallyMcGrath SallyMcGrath deleted the feature/sprints branch December 5, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View sprints in modules on PD Page
2 participants